Thanks to visit codestin.com
Credit goes to github.com

Skip to content

merge 1.7.3 docs into gh-pages branch; closes upstream #235 #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

mcdonc
Copy link
Contributor

@mcdonc mcdonc commented Jun 25, 2018

Built via "build" script in docs dir within v1.7.3 branch, copied reuslting files to fork's gh-pages here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2018
@tseaver
Copy link
Contributor

tseaver commented Jun 25, 2018

Can you edit the commit message (using git commit --amend) and put the following on a separate line?

Closes #235

That will get the issue automagically closed on merge.

Then git push -f origin/gh-pages.

@mcdonc
Copy link
Contributor Author

mcdonc commented Jul 2, 2018

What has to happen to get this merged?

@tseaver
Copy link
Contributor

tseaver commented Jul 11, 2018

@mcdonc

What has to happen to get this merged?

CI is green, you have an approved review --> you push the green "Squash and merge" button. :)

@mcdonc mcdonc merged commit cdac1ef into googleapis:gh-pages Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants