Support methodPath entries containing colon. #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if we have a top-level methodPath of the form `path:methodName`, we'll pass this to `urlparse.urljoin`, where this is interpreted as `scheme:netloc`. In cases other than media upload, this is **not** what we want. This fixes the issue by adding our own custom `urljoin`, which detects and handles this case. We also add a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we have a top-level methodPath of the form
path:methodName,we'll pass this to
urlparse.urljoin, where this is interpreted asscheme:netloc. In cases other than media upload, this is not what wewant.
This fixes the issue by adding our own custom
urljoin, which detects andhandles this case. We also add a test.
PTAL @nathanielmanistaatgoogle