Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix HttpRequest json dump #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix HttpRequest json dump #565

wants to merge 1 commit into from

Conversation

vianney-g
Copy link

Response callbacks are not JSON serializable and should be excluded from
json dump.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2018
@vianney-g vianney-g force-pushed the fix-http-request-json-dump branch from d2fa1eb to fc4d5e8 Compare August 28, 2018 14:21
benamar
benamar approved these changes Nov 13, 2018
View reviewed changes
Copy link

@benamar benamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@sduskis sduskis requested a review from a team December 7, 2018 03:53
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2018
@vianney-g vianney-g force-pushed the fix-http-request-json-dump branch from fc4d5e8 to 7dfdded Compare January 14, 2019 16:11
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Feb 7, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Feb 7, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
yoshi-automation added a commit that referenced this pull request May 27, 2020
@yoshi-automation
chore(python): remove one remaining extra bash line (#565)
45940d6 
To avoid generating bogus PRs

Co-authored-by: Jeffrey Rennie <[email protected]>

Source-Author: Carlos de la Guardia <[email protected]>
Source-Date: Tue May 19 11:57:19 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e
Source-Link: googleapis/synthtool@d2364eb
gcf-merge-on-green bot pushed a commit that referenced this pull request May 28, 2020
@yoshi-automation
chore(python): remove one remaining extra bash line (#565) (#921)
510d17a 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/114f5035-f0cf-4ea6-8fee-cdb41d93a838/targets

Source-Link: googleapis/synthtool@d2364eb
@vianney-g vianney-g force-pushed the fix-http-request-json-dump branch from 7dfdded to fcbec41 Compare July 1, 2020 14:17
fix: HttpRequest json dump crashes if response callbacks
efd132f 
Response callbacks are not JSON serializable and should be excluded from
json dump.
@vianney-g vianney-g force-pushed the fix-http-request-json-dump branch from fcbec41 to efd132f Compare July 1, 2020 14:19
@vianney-g vianney-g removed the request for review from a team July 1, 2020 14:51
@busunkim96 busunkim96 closed this Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benamar benamar benamar approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vianney-g @benamar @JustinBeckwith @googlebot @busunkim96 @kokoro-team @yoshi-automation