Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the client to respect the passed in developerKey and credentials #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2018
Merged

Fix the client to respect the passed in developerKey and credentials #593

merged 2 commits into from
Nov 30, 2018

Conversation

arunpn123
Copy link
Contributor

Issue: #562

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 29, 2018
42B
42B reviewed Nov 29, 2018
View reviewed changes
Copy link

@42B 42B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not developer_key?

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2018
@busunkim96 busunkim96 self-assigned this Nov 29, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2018
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2018
@busunkim96 busunkim96 merged commit 9d779cc into googleapis:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42B 42B 42B left review comments

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arunpn123 @busunkim96 @42B @googlebot @kokoro-team