Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding coveralls integration #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2015

Conversation

pferate
Copy link
Contributor

@pferate pferate commented Mar 27, 2015

Run coverage with all tests and send results to coveralls.io.

This was added to oauth2client and I figured we should add it here as well.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 27, 2015

[testenv:py27]
commands = nosetests
commands = {[testenv:py26]commands}

This comment was marked as spam.

This comment was marked as spam.

@nathanielmanistaatgoogle
Copy link
Contributor

When I look at oauth2client's coveralls setup, I see "cover" as its own tox environment. Why is that not the right thing to do here?

@pferate
Copy link
Contributor Author

pferate commented Mar 27, 2015

We will probably want to fix that in oauth2client. Right now, it only checks the coverage in 2.7. The way it is implemented there, the nose tests are ran normally first, then in 2.7, the nose tests are ran again with the coverage check; so the test are running twice when only once is needed (per version).

I don't see a reason to not check the coverage for all versions when the tests are ran the first time, since some of the code only runs in 2.x and others only in 3.x. Coveralls will also give you a summary for all of the test environments afterwards.

@pferate
Copy link
Contributor Author

pferate commented Mar 27, 2015

Ok, I cleaned up the tox config file a lot and updated the PR.

unittest2
setenv = PYTHONPATH=../google_appengine

[testenv:py26]
commands = nosetests --ignore-files=test_oauth2client_appengine\.py

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

pferate added 2 commits March 30, 2015 07:45
The oauth2client unit tests were removed, but some of the tox settings
were left straggling.  Removing them cleans up the config file a lot.
Run coverage with all tests and send results to coveralls.io.
@pferate
Copy link
Contributor Author

pferate commented Mar 30, 2015

Split the commit into 2, how's it look now?

nathanielmanistaatgoogle added a commit that referenced this pull request Mar 30, 2015
Adding coveralls integration
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit c926756 into googleapis:master Mar 30, 2015
@nathanielmanistaatgoogle
Copy link
Contributor

Looks much better; thanks!

akrherz pushed a commit to akrherz/google-api-python-client that referenced this pull request Apr 1, 2019
Fix re-raising exceptions in locked file to preserve stack trace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants