Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: use older version of nox to fix test failure #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: use older version of nox to fix test failure #923

wants to merge 1 commit into from

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented May 27, 2020 •
edited
Loading

latest version (2020.5.24) of nox breaks all unit tests, we have to use the previous version (2019.11.9). As a comparison, this "empty" PR #922 uses the latest version and all unit tests fail. #921 fails for the same reason.

Session unit-2.7 raised exception TypeError("unit() missing 1 required positional argument: 'oauth2client'",)
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/nox/sessions.py", line 462, in execute
    self.func(session)
  File "/usr/local/lib/python3.6/site-packages/nox/_decorators.py", line 53, in __call__
    return self.func(*args, **kwargs)
TypeError: unit() missing 1 required positional argument: 'oauth2client'

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2020
@arithmetic1728 arithmetic1728 marked this pull request as draft May 27, 2020 19:01
@arithmetic1728 arithmetic1728 marked this pull request as ready for review May 27, 2020 19:13
@arithmetic1728 arithmetic1728 requested a review from busunkim96 May 27, 2020 19:19
@arithmetic1728 arithmetic1728 deleted the sijun-test-2 branch June 2, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arithmetic1728 @bryanlaura736 @googlebot