feat: Add iam endpoint override to ImpersonatedCredentials #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0fea3f6 to
08a64fd
Compare
…onated credential url change
lsirac
reviewed
Apr 12, 2022
oauth2_http/javatests/com/google/auth/oauth2/ImpersonatedCredentialsTest.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ImpersonatedCredentialsTest.java
Show resolved
Hide resolved
…ride endpoint correctly and added test
Neenu1995
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See go/service-account-impersonation-url-override.
Changes behavior of ImpersonatedCredentials to use the provided serviceAccountImpersonation URL from the credential configuration when available instead of only using the hardcoded default URL + target principal.