Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Add googleapis-auth as codeowner team #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2022
Merged

chore: Add googleapis-auth as codeowner team #950

merged 2 commits into from
Jul 25, 2022

Conversation

lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Jul 22, 2022 •
edited by meltsufin
Loading

BEGIN_COMMIT_OVERRIDE
chore: Add googleapis-auth as codeowner team
END_COMMIT_OVERRIDE

@lqiu96 lqiu96 requested a review from a team as a code owner July 22, 2022 20:05
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 22, 2022
alicejli
alicejli reviewed Jul 22, 2022
View reviewed changes
.github/CODEOWNERS
* @googleapis/yoshi-java
# The @googleapis/googleapis-auth is the default owner for changes in this repo
* @googleapis/yoshi-java @googleapis/googleapis-auth
**/*.java @googleapis/googleapis-auth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dumb q- what does line 9 do? Seems like line 8 is giving @googleapis/googleapis-auth edit access to all the files in the repo already, so is line 9 redundant?

Copy link
Member Author

@lqiu96 lqiu96 Jul 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe from the docs (https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file), the last matching pattern takes precedence. For any non *.java files, yoshi-java and googleapis-auth should be able to approve, but only googleapis-auth is allowed to approve for *.java (and samples.java has their own rule)

These changes are from owlbot (and I believe from the template in the synthtool).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OwlBot doesn't control this repository's Java code.

alicejli
alicejli reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@alicejli alicejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question in comments - otherwise, looks good.

TimurSadykov
TimurSadykov approved these changes Jul 22, 2022
View reviewed changes
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

suztomo
suztomo approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead with granting the Write role to the new team. This removed the warning message.

@lqiu96 lqiu96 merged commit ef17ed8 into main Jul 25, 2022
@lqiu96 lqiu96 deleted the auth_team_permissions branch July 25, 2022 16:33
@release-please release-please bot mentioned this pull request Jul 25, 2022
Closed
@meltsufin
Copy link
Member

BTW, please use chore: for these kinds of changes so that it works well with release-please.
See: https://www.conventionalcommits.org/en/v1.0.0/.

@meltsufin meltsufin changed the title feat: Add googleapis-auth as codeowner team chore: Add googleapis-auth as codeowner team Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

+2 more reviewers

@alicejli alicejli alicejli left review comments

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lqiu96 @meltsufin @suztomo @TimurSadykov @alicejli