fix: Circular Dependencies Issue #1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me, and I see why adding a test won't really be helpful, but I guess I can't know for sure if this solves the circular dependency issue since it's hard to follow the graph without visualizing it. It might be good just to test locally and make sure this does solve the problem with something like madge, but NB. |
sofisl
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some circular dependency issues in both:
Without this change, ESM cannot be supported in the library in the future. Some tools do not properly build this library due to this bug.
We would have implicit testing for this in the future through the introduction of either ESM support or esbuild.
Fixes #1539 🦕