Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add detection for Cloud Run Jobs #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

feat: add detection for Cloud Run Jobs #2120

merged 1 commit into from
Aug 25, 2025

Conversation

Daniel-Aaron-Bloom
Copy link
Contributor

Description

This adds detection for Cloud Run Jobs via the CLOUD_RUN_JOB env var. This is motivated by bugs like like googleapis/nodejs-logging#1590.

Impact

Cloud Run Jobs are no longer detected as Compute Engine.

Testing

Copied Cloud Run Env detection test.

Checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease
  • Appropriate docs were updated
  • Appropriate comments were added, particularly in complex areas or places that require background
  • No new warnings or issues will be generated from this change

Fixes #2119

@Daniel-Aaron-Bloom Daniel-Aaron-Bloom requested review from a team as code owners August 20, 2025 03:50
@google-cla Google CLA
Copy link

google-cla bot commented Aug 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 20, 2025
@Daniel-Aaron-Bloom Daniel-Aaron-Bloom mentioned this pull request Aug 20, 2025
Open
4 tasks
@feywind feywind merged commit b659124 into googleapis:main Aug 25, 2025
13 of 15 checks passed
@release-please release-please bot mentioned this pull request Aug 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

@feywind feywind feywind approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCPEnv to detect more GCP services (Cloud Run Job)
3 participants
@Daniel-Aaron-Bloom @sofisl @feywind