chore: remove server superglobal support#616
Merged
Conversation
Hectorhammett
approved these changes
Apr 15, 2025
Contributor
|
Hi @bshaffer, Totally agree things should be kept as simple and semantic as possible 👍 After some quick tests, Try the following script: <?php
var_dump($_ENV);
var_dump($_SERVER);
So learning about this, keeping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #612
Remove use of
$_SERVERas it isn't really necessary to support it.A bit picky of me, but I'd like to keep things as simple as possible.
cc @jannes-io