Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add timeout parameter to AuthorizedSession.request() #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

feat: add timeout parameter to AuthorizedSession.request() #397

merged 1 commit into from
Dec 9, 2019

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Dec 5, 2019 •
edited
Loading

Fixes #396.

  • Still needs a few extra tests, but outlining the general idea here.

cc: @tswast

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2019
@plamut plamut mentioned this pull request Dec 6, 2019
Merged
5 tasks
@plamut plamut force-pushed the add-timeout-param branch 2 times, most recently from 058e855 to 74ceefa Compare December 6, 2019 23:03
@plamut plamut marked this pull request as ready for review December 6, 2019 23:03
@plamut plamut requested review from busunkim96 and tswast December 6, 2019 23:04
@plamut plamut force-pushed the add-timeout-param branch from 74ceefa to 94276e8 Compare December 6, 2019 23:24
@plamut plamut force-pushed the add-timeout-param branch from 94276e8 to cc243e4 Compare December 9, 2019 07:09
@busunkim96 busunkim96 changed the title Add timeout parameter to AuthorisedSession.request() feat: add timeout parameter to AuthorizedSession.request() Dec 9, 2019
@busunkim96 busunkim96 merged commit 381dd40 into googleapis:master Dec 9, 2019
busunkim96 added a commit that referenced this pull request Dec 9, 2019
@busunkim96
Revert "feat: add timeout to AuthorizedSession.request() (#397)"
de01bff 
This reverts commit 381dd40.
@busunkim96 busunkim96 mentioned this pull request Dec 9, 2019
Merged
busunkim96 added a commit that referenced this pull request Dec 9, 2019
@busunkim96
fix: revert "feat: add timeout to AuthorizedSession.request() (#397)" (…
451ecbd 
…#401)

This reverts commit 381dd40.
@busunkim96 busunkim96 mentioned this pull request Dec 9, 2019
Closed
This was referenced Dec 10, 2019
Closed
Merged
@yoshi-automation yoshi-automation mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast Awaiting requested review from tswast

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add timeout parameter to AuthorizedSession.request()
3 participants
@plamut @busunkim96 @googlebot