Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(bigquery-jdbc): fix flaky testSetTimeout test #13549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logachev merged 5 commits into from
Jun 24, 2026
+14 −47
Merged

chore(bigquery-jdbc): fix flaky testSetTimeout test #13549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a21cd7
chore(bigquery-jdbc): fix flaky testSetTimeout test
logachev Jun 24, 2026
224a49f
feedback
logachev Jun 24, 2026
d0aba84
cleanup
logachev Jun 24, 2026
1e167a8
fix test
logachev Jun 24, 2026
de6eb36
fix error msg
logachev Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@

public class ITBase extends BigQueryJdbcBaseTest {

// This query takes 300 seconds to complete
public static final String query300seconds =
"DECLARE DELAY_TIME DATETIME; SET DELAY_TIME = DATETIME_ADD(CURRENT_DATETIME, INTERVAL 300"
+ " SECOND); WHILE CURRENT_DATETIME < DELAY_TIME DO END WHILE;";
Comment thread
logachev marked this conversation as resolved.

private static String sharedDataset;
private static String sharedDataset2;

Expand Down
24 changes: 3 additions & 21 deletions ...-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITNightlyBigQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;

public class ITNightlyBigQueryTest {
public class ITNightlyBigQueryTest extends ITBase {
Comment thread
logachev marked this conversation as resolved.
static final String PROJECT_ID = ServiceOptions.getDefaultProjectId();
static Connection bigQueryConnection;
static Statement bigQueryStatement;
Expand Down Expand Up @@ -215,18 +215,13 @@ public void testQueryInterruptGracefullyStopsExplicitJob()
DriverManager.getConnection(connection_uri + ";JobCreationMode=1", new Properties());
Statement bigQueryStatement = bigQueryConnection.createStatement();

// This query takes 300 seconds to complete
String query300Seconds =
"DECLARE DELAY_TIME DATETIME; SET DELAY_TIME = DATETIME_ADD(CURRENT_DATETIME, INTERVAL 300"
+ " SECOND); WHILE CURRENT_DATETIME < DELAY_TIME DO END WHILE;";

// Query will be started in the background thread & we will call cancel from current thread.
Thread t =
new Thread(
() -> {
SQLException e =
assertThrows(
SQLException.class, () -> bigQueryStatement.execute(query300Seconds));
SQLException.class, () -> bigQueryStatement.execute(ITBase.query300seconds));
assertTrue(e.getMessage().contains("User requested cancellation"));
threadException.set(false);
});
Expand Down Expand Up @@ -254,18 +249,13 @@ public void testQueryInterruptGracefullyStopsOptionalJob()
DriverManager.getConnection(connection_uri + ";JobCreationMode=2", new Properties());
Statement bigQueryStatement = bigQueryConnection.createStatement();

// This query takes 300 seconds to complete
String query300Seconds =
"DECLARE DELAY_TIME DATETIME; SET DELAY_TIME = DATETIME_ADD(CURRENT_DATETIME, INTERVAL 300"
+ " SECOND); WHILE CURRENT_DATETIME < DELAY_TIME DO END WHILE;";

// Query will be started in the background thread & we will call cancel from current thread.
Thread t =
new Thread(
() -> {
SQLException e =
assertThrows(
SQLException.class, () -> bigQueryStatement.execute(query300Seconds));
SQLException.class, () -> bigQueryStatement.execute(ITBase.query300seconds));
assertTrue(e.getMessage().contains("Query was cancelled."));
threadException.set(false);
});
Expand Down Expand Up @@ -1684,12 +1674,4 @@ private String getSessionId() throws InterruptedException {
Job stubJob = bigQuery.getJob(job.getJobId());
return stubJob.getStatistics().getSessionInfo().getSessionId();
}

private int resultSetRowCount(ResultSet resultSet) throws SQLException {
int rowCount = 0;
while (resultSet.next()) {
rowCount++;
}
return rowCount;
}
}
32 changes: 6 additions & 26 deletions java-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/it/ITStatementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package com.google.cloud.bigquery.jdbc.it;

import static com.google.common.truth.Truth.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
Expand Down Expand Up @@ -48,7 +49,7 @@
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

public class ITStatementTest {
public class ITStatementTest extends ITBase {
Comment thread
logachev marked this conversation as resolved.
private static final String DEFAULT_CATALOG = ServiceOptions.getDefaultProjectId();
private static String DATASET;
private static Random random = new Random();
Expand Down Expand Up @@ -122,7 +123,7 @@ public void testExecuteQuery() throws SQLException {
// setMaxRows Test
statement.setMaxRows(5);
ResultSet maxRowsResultSet = statement.executeQuery(selectQuery);
assertEquals(5, getSizeOfResultSet(maxRowsResultSet));
assertEquals(5, resultSetRowCount(maxRowsResultSet));

try {
statement.setMaxRows(0);
Expand Down Expand Up @@ -244,14 +245,6 @@ public void testScript() throws SQLException {
connection.close();
}

private int resultSetRowCount(ResultSet resultSet) throws SQLException {
int rowCount = 0;
while (resultSet.next()) {
rowCount++;
}
return rowCount;
}

@Test
public void testStringColumnLength() throws SQLException {
String TABLE_NAME = "StringColumnLengthTable";
Expand Down Expand Up @@ -323,18 +316,13 @@ public void testSetTimeout() throws SQLException {
Connection connection = DriverManager.getConnection(ITBase.connectionUrl);
Statement statement = connection.createStatement();

String selectQuery =
"SELECT views FROM bigquery-public-data.wikipedia.pageviews_2020 WHERE datehour >="
+ " '2020-01-01' LIMIT 9000000";

// statement.execute(selectQuery);
assertEquals(0, statement.getQueryTimeout());
statement.setQueryTimeout(1);
assertEquals(1, statement.getQueryTimeout());
SQLException e = assertThrows(SQLException.class, () -> statement.executeQuery(selectQuery));
assertEquals(
"BigQueryException during runQuery\nJob execution was cancelled: Job timed out",
e.getMessage());
SQLException e =
assertThrows(SQLException.class, () -> statement.executeQuery(ITBase.query300seconds));
assertThat(e.getMessage()).contains("Job execution was cancelled: Job timed out");
statement.close();
connection.close();
}
Expand Down Expand Up @@ -388,14 +376,6 @@ public void testRangeSelectDataset() throws SQLException {
connection.close();
}

int getSizeOfResultSet(ResultSet resultSet) throws SQLException {
int count = 0;
while (resultSet.next()) {
count++;
}
return count;
}

Comment thread
logachev marked this conversation as resolved.
@Test
public void testTemporaryDatasetLocation() throws SQLException, InterruptedException {
String projectId = DEFAULT_CATALOG;
Expand Down
Loading