Create packages for resource manager and outline spi layer. #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
d240f95 to
e3ca489
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
For the record, we agreed to keep naming style and directory style consistent (gcloud-java-resourcemanage). |
…to pom files spi api fixes
|
@aozarov comments incorporated |
|
@aozarov updated to include comments. I also changed "hasPermissions" to take varargs instead of a list. I think varargs are probably nicer for anybody using the low-level api, because they may only test one or two permissions at a time. Edit: will put this in the api layer, not the spi layer |
dcd9534 to
51f5311
Compare
51f5311 to
10904d9
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@aozarov comments included, and I added |
|
We could probably add a return type for |
5a3dfb4 to
0f292cb
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Hey @ajkannan. Looks good, few nits and a couple of questions. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@aozarov comments addressed, removed extraneous enums, and changed "update"/"set" terminology to "replace" |
aozarov
added a commit
that referenced
this pull request
Nov 4, 2015
Create packages for resource manager and outline spi layer.
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
…to v3.6.1 (googleapis#314) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-channel](https://togithub.com/googleapis/java-) | `3.6.0` -> `3.6.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-channel).
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
…s to v2 (#314) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-workflows](https://togithub.com/googleapis/java-workflows) | `1.0.2` -> `2.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | *** ### Release Notes <details> <summary>googleapis/java-workflows</summary> ### [`v2.0.0`](https://togithub.com/googleapis/java-workflows/blob/master/CHANGELOG.md#200-httpswwwgithubcomgoogleapisjava-workflowscomparev102v200-2021-08-06) [Compare Source](https://togithub.com/googleapis/java-workflows/compare/v1.0.2...v2.0.0) ##### ⚠ BREAKING CHANGES * release gapic-generator-java v2.0.0 ([#308](https://togithub.com/googleapis/java-workflows/issues/308)) ##### Features * release gapic-generator-java v2.0.0 ([#308](https://www.togithub.com/googleapis/java-workflows/issues/308)) ([1541cad](https://www.togithub.com/googleapis/java-workflows/commit/1541cadec04194a9e07f4f5af11310811ac61de1)) ##### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2 ([#309](https://www.togithub.com/googleapis/java-workflows/issues/309)) ([aed6c3d](https://www.togithub.com/googleapis/java-workflows/commit/aed6c3dae4825c830dbb21b86798d3c6c91cb2a7)) ##### [1.0.2](https://www.togithub.com/googleapis/java-workflows/compare/v1.0.1...v1.0.2) (2021-07-01) ##### Bug Fixes * Add `shopt -s nullglob` to dependencies script ([#1130](https://www.togithub.com/googleapis/java-workflows/issues/1130)) ([#286](https://www.togithub.com/googleapis/java-workflows/issues/286)) ([2101cc5](https://www.togithub.com/googleapis/java-workflows/commit/2101cc52ff37168707b9b91719356eccea5437b5)) ##### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.4.0 ([#288](https://www.togithub.com/googleapis/java-workflows/issues/288)) ([2dd7b14](https://www.togithub.com/googleapis/java-workflows/commit/2dd7b1409e38745666e5b8aa179bc6f403dc460c)) ##### [1.0.1](https://www.togithub.com/googleapis/java-workflows/compare/v1.0.0...v1.0.1) (2021-06-09) ##### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.3.0 ([#274](https://www.togithub.com/googleapis/java-workflows/issues/274)) ([fa83b51](https://www.togithub.com/googleapis/java-workflows/commit/fa83b51413dd911f4bced55e68c084517f5a5981)) </details> *** ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. *** * \[ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. *** This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-workflows).
github-actions bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
…onfig to v1.5.1 (#314) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.0` -> `1.5.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.1`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​151-httpsgithubcomgoogleapisjava-shared-configcomparev150v151-2022-06-30) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.0...v1.5.1) ##### Dependencies - update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([#​482](https://togithub.com/googleapis/java-shared-config/issues/482)) ([fbfc6dc](https://togithub.com/googleapis/java-shared-config/commit/fbfc6dc1329faaead3a3114c8599d9267722e7f0)) - update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#​483](https://togithub.com/googleapis/java-shared-config/issues/483)) ([336cb78](https://togithub.com/googleapis/java-shared-config/commit/336cb7827b36583228c9e2b85871ae72f4c55975)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-contact-center-insights).
github-actions bot
pushed a commit
to renovate-bot/google-cloud-java
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to yoshi-code-bot/google-cloud-java
that referenced
this pull request
Oct 6, 2022
…-metastore to v2.4.4 (googleapis#314) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-dataproc-metastore](https://togithub.com/googleapis/java-dataproc-metastore) | `2.4.3` -> `2.4.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dataproc-metastore). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNi4wIn0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
* chore: [java] generation with shared deps 3.0.4 * fix for tests Source-Link: https://togithub.com/googleapis/synthtool/commit/c3ad3cc9d876a3dd897cc511cf5ef921784851ae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:5643a4e1b729803e67ddceee450e87052527b37cac394bf900b4f8e3d1bb3e9b
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ### [1.2.11](googleapis/java-iam@v1.2.10...v1.2.11) (2022-03-25) ### Dependencies * update dependency com.google.api:api-common to v2.1.5 ([#313](googleapis/java-iam#313)) ([08a700e](googleapis/java-iam@08a700e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I named the module "gcloud-java-resource-manager" (with a dash between "resource" and "manager"). For the package name I didn't separate the words (it's com.google.gcloud.resourcemanager). Let me know if it would be better to standardize and name the module "gcloud-java-resourcemanager."