Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added Query#fromProto to convert protobuf ReadRowsRequest #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JesseLovelace merged 6 commits into from
Jan 9, 2019
Merged

Added Query#fromProto to convert protobuf ReadRowsRequest #4291

JesseLovelace merged 6 commits into from
Jan 9, 2019

Conversation

@rahulKQL
Copy link

@rahulKQL rahulKQL commented Jan 4, 2019

For fixes related to #4260

This PR is to add a method in Query.java

@rahulKQL rahulKQL requested a review from a team as a code owner January 4, 2019 16:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 4, 2019
igorbernstein2
igorbernstein2 suggested changes Jan 4, 2019
View reviewed changes
...ents/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Query.java Outdated
public static Query fromProto(ReadRowsRequest request) {
Preconditions.checkArgument(request != null, "ReadRowsRequest must not be null");

TableName tableName = TableName.parse(request.getTableName());

This comment was marked as spam.

Sign in to view

...ents/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Query.java Outdated
* and not meant to be used by applications.
*/
@InternalApi
public static Query fromProto(ReadRowsRequest request) {

This comment was marked as spam.

Sign in to view

...ents/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Query.java Outdated
String tableId = "";
if (tableName != null) {
tableId = tableName.getTable();
}

This comment was marked as spam.

Sign in to view

...ents/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Query.java Outdated
}

Query query = new Query(tableId);
query.builder = ReadRowsRequest.newBuilder(request);

This comment was marked as spam.

Sign in to view

.../google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/QueryTest.java Outdated
@Test
public void testFromProto() {
ReadRowsRequest request = ReadRowsRequest.newBuilder()
.setTableName(TABLE_NAME.toString())

This comment was marked as spam.

Sign in to view

.../google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/QueryTest.java
}

@Test
public void testFromProtoWithEmptyTableId() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@googlebot
Copy link

googlebot commented Jan 8, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 8, 2019
@rahulKQL rahulKQL changed the base branch from master to ignoretest January 8, 2019 12:15
@rahulKQL rahulKQL changed the base branch from ignoretest to master January 8, 2019 12:15
igorbernstein2
igorbernstein2 approved these changes Jan 8, 2019
View reviewed changes
Copy link

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the docs are updated

...ents/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Query.java Outdated
* Wraps the protobuf {@link ReadRowsRequest}. This method is considered an internal implementation detail
* and not meant to be used by applications.
*
* <p>WARNING: ProjectId & InstanceId of {@link ReadRowsRequest} would be ignored.

This comment was marked as spam.

Sign in to view

@sduskis sduskis added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 8, 2019
@googlebot
Copy link

googlebot commented Jan 8, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2019
@googlebot
Copy link

googlebot commented Jan 9, 2019

CLAs look good, thanks!

igorbernstein2
igorbernstein2 approved these changes Jan 9, 2019
View reviewed changes
Copy link

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 9, 2019
@JesseLovelace JesseLovelace merged commit 3d11659 into googleapis:master Jan 9, 2019
@kolea2 kolea2 mentioned this pull request Jan 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sduskis sduskis sduskis left review comments

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Milestone

No milestone