-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add SequentialExecutorService that assists Pub/Sub to publish messages sequentially #4315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kolea2
merged 3 commits into
googleapis:pubsub-ordering-keys
from
kimkyung-goog:pubsub-keys
Feb 8, 2019
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
263 changes: 263 additions & 0 deletions
263
...ogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/SequentialExecutorService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,263 @@ | ||
| /* | ||
| * Copyright 2019 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.pubsub.v1; | ||
|
|
||
| import com.google.api.core.ApiFuture; | ||
| import com.google.api.core.ApiFutureCallback; | ||
| import com.google.api.core.ApiFutures; | ||
| import com.google.api.core.SettableApiFuture; | ||
| import java.util.Deque; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.concurrent.Callable; | ||
| import java.util.concurrent.CancellationException; | ||
| import java.util.concurrent.ConcurrentLinkedDeque; | ||
| import java.util.concurrent.Executor; | ||
| import java.util.logging.Level; | ||
| import java.util.logging.Logger; | ||
|
|
||
| interface CancellableRunnable extends Runnable { | ||
| public void cancel(Throwable e); | ||
| } | ||
|
|
||
| /** | ||
| * An executor service that runs the tasks with the same key sequentially. The tasks with the same | ||
| * key will be run only when its predecessor has been completed while tasks with different keys can | ||
| * be run in parallel. | ||
| */ | ||
| final class SequentialExecutorService<T> { | ||
| private static final Logger logger = Logger.getLogger(SequentialExecutorService.class.getName()); | ||
|
|
||
| private final SequentialExecutor manageableSequentialExecutor; | ||
| private final SequentialExecutor autoSequentialExecutor; | ||
|
|
||
| SequentialExecutorService(Executor executor) { | ||
| this.manageableSequentialExecutor = | ||
| SequentialExecutor.newManageableSequentialExecutor(executor); | ||
| this.autoSequentialExecutor = SequentialExecutor.newAutoSequentialExecutor(executor); | ||
| } | ||
|
|
||
| /** | ||
| * Runs asynchronous {@code Callable} tasks sequentially. If one of the tasks fails, other tasks | ||
| * with the same key that have not been executed will be cancelled. | ||
| */ | ||
| ApiFuture<T> submit(final String key, final Callable<ApiFuture> callable) { | ||
| final SettableApiFuture<T> future = SettableApiFuture.<T>create(); | ||
| manageableSequentialExecutor.execute( | ||
| key, | ||
| new CancellableRunnable() { | ||
| private boolean cancelled = false; | ||
|
|
||
| @Override | ||
| public void run() { | ||
| if (cancelled) { | ||
| return; | ||
| } | ||
| try { | ||
| ApiFuture<T> callResult = callable.call(); | ||
| ApiFutures.addCallback( | ||
| callResult, | ||
| new ApiFutureCallback<T>() { | ||
| @Override | ||
| public void onSuccess(T msg) { | ||
| future.set(msg); | ||
| manageableSequentialExecutor.resume(key); | ||
| } | ||
|
|
||
| @Override | ||
| public void onFailure(Throwable e) { | ||
| future.setException(e); | ||
| manageableSequentialExecutor.cancelQueuedTasks( | ||
| key, | ||
| new CancellationException( | ||
| "Execution cancelled because executing previous runnable failed.")); | ||
| } | ||
| }); | ||
| } catch (Exception e) { | ||
| future.setException(e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void cancel(Throwable e) { | ||
| this.cancelled = true; | ||
| future.setException(e); | ||
| } | ||
| }); | ||
| return future; | ||
| } | ||
|
|
||
| /** Runs synchronous {@code Runnable} tasks sequentially. */ | ||
| public void submit(final String key, final Runnable runnable) { | ||
| autoSequentialExecutor.execute(key, runnable); | ||
| } | ||
|
|
||
| /** | ||
| * Internal implemenation of SequentialExecutorService. Takes a serial stream of string keys and | ||
| * {@code Runnable} tasks, and runs the tasks with the same key sequentially. Tasks with the same | ||
| * key will be run only when its predecessor has been completed while tasks with different keys | ||
| * can be run in parallel. | ||
| */ | ||
| static class SequentialExecutor { | ||
| // Maps keys to tasks. | ||
| private final Map<String, Deque<Runnable>> tasksByKey; | ||
| private final Executor executor; | ||
|
|
||
| enum TaskCompleteAction { | ||
| EXECUTE_NEXT_TASK, | ||
| WAIT_UNTIL_RESUME, | ||
| } | ||
|
|
||
| private TaskCompleteAction taskCompleteAction; | ||
|
|
||
| /** | ||
| * Creates a AutoSequentialExecutor which executes the next queued task automatically when the | ||
| * previous task has completed. | ||
| */ | ||
| public static SequentialExecutor newAutoSequentialExecutor(Executor executor) { | ||
| return new SequentialExecutor(executor, TaskCompleteAction.EXECUTE_NEXT_TASK); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a ManageableSequentialExecutor which allows users to decide when to execute the next | ||
| * queued task. The first queued task is executed immediately, but the following tasks will be | ||
| * executed only when {@link #resume(String)} is called explicitly. | ||
| */ | ||
| static SequentialExecutor newManageableSequentialExecutor(Executor executor) { | ||
| return new SequentialExecutor(executor, TaskCompleteAction.WAIT_UNTIL_RESUME); | ||
| } | ||
|
|
||
| private SequentialExecutor(Executor executor, TaskCompleteAction taskCompleteAction) { | ||
| this.executor = executor; | ||
| this.taskCompleteAction = taskCompleteAction; | ||
| this.tasksByKey = new HashMap<>(); | ||
| } | ||
|
|
||
| public void execute(final String key, Runnable task) { | ||
| Deque<Runnable> newTasks; | ||
| synchronized (tasksByKey) { | ||
| newTasks = tasksByKey.get(key); | ||
| // If this key is already being handled, add it to the queue and return. | ||
| if (newTasks != null) { | ||
| newTasks.add(task); | ||
kolea2 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return; | ||
| } | ||
|
|
||
| newTasks = new ConcurrentLinkedDeque(); | ||
| newTasks.add(task); | ||
| tasksByKey.put(key, newTasks); | ||
| } | ||
|
|
||
| final Deque<Runnable> finalTasks = newTasks; | ||
| executor.execute( | ||
| new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| switch (taskCompleteAction) { | ||
| case EXECUTE_NEXT_TASK: | ||
| invokeCallbackAndExecuteNext(key, finalTasks); | ||
| break; | ||
| case WAIT_UNTIL_RESUME: | ||
| invokeCallback(finalTasks); | ||
| break; | ||
| default: | ||
| // Nothing to do. | ||
| } | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| /** Cancels every task in the queue assoicated with {@code key}. */ | ||
| public void cancelQueuedTasks(final String key, Throwable e) { | ||
| // TODO(kimkyung-goog): Ensure execute() fails once cancelQueueTasks() has been ever invoked, | ||
| // so that no more tasks are scheduled. | ||
| synchronized (tasksByKey) { | ||
| final Deque<Runnable> tasks = tasksByKey.get(key); | ||
| if (tasks == null) { | ||
| return; | ||
kolea2 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| while (!tasks.isEmpty()) { | ||
| Runnable task = tasks.poll(); | ||
| if (task instanceof CancellableRunnable) { | ||
kolea2 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ((CancellableRunnable) task).cancel(e); | ||
| } else { | ||
| logger.log( | ||
| Level.WARNING, | ||
| "Attempted to cancel Runnable that was not CancellableRunnable; ignored."); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** Executes the next queued task associated with {@code key}. */ | ||
| public void resume(final String key) { | ||
| if (taskCompleteAction.equals(TaskCompleteAction.EXECUTE_NEXT_TASK)) { | ||
| // resume() is no-op since tasks are executed automatically. | ||
| return; | ||
| } | ||
| Deque<Runnable> tasks; | ||
| synchronized (tasksByKey) { | ||
| tasks = tasksByKey.get(key); | ||
| if (tasks == null) { | ||
| return; | ||
| } | ||
| if (tasks.isEmpty()) { | ||
| tasksByKey.remove(key); | ||
| return; | ||
| } | ||
| } | ||
| final Deque<Runnable> finalTasks = tasks; | ||
| // Run the next task. | ||
| executor.execute( | ||
| new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| invokeCallback(finalTasks); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| private void invokeCallback(final Deque<Runnable> tasks) { | ||
| // TODO(kimkyung-goog): Check if there is a race when task list becomes empty. | ||
| Runnable task = tasks.poll(); | ||
| if (task != null) { | ||
| task.run(); | ||
| } | ||
| } | ||
|
|
||
| private void invokeCallbackAndExecuteNext(final String key, final Deque<Runnable> tasks) { | ||
| invokeCallback(tasks); | ||
| synchronized (tasksByKey) { | ||
| if (tasks.isEmpty()) { | ||
| // Note that there can be a race if a task is added to `tasks` at this point. However, | ||
| // tasks.add() is called only inside the block synchronized by `tasksByKey` object | ||
| // in the execute() function. Therefore, we are safe to remove `tasks` here. This is not | ||
| // optimal, but correct. | ||
| tasksByKey.remove(key); | ||
| return; | ||
| } | ||
| } | ||
| executor.execute( | ||
| new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| invokeCallbackAndExecuteNext(key, tasks); | ||
| } | ||
| }); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.