Core: Default executor used non-daemon threads #5194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default executor for GrpcTransportOptions created non-daemon threads possibly keeping applications alive after the main method has finished. This is the cause of googleapis#2315.
Codecov Report
@@ Coverage Diff @@
## master #5194 +/- ##
============================================
+ Coverage 50.41% 50.42% +<.01%
Complexity 23796 23796
============================================
Files 2251 2251
Lines 226833 226836 +3
Branches 24966 24966
============================================
+ Hits 114368 114371 +3
Misses 103858 103858
Partials 8607 8607
Continue to review full report at Codecov.
|
sduskis
approved these changes
May 17, 2019
Contributor
|
This is a great find. |
This was referenced May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default executor for GrpcTransportOptions created non-daemon threads, possibly keeping applications alive after the main method has finished.
Note: While this fixes #2315, I do not know whether this could cause unwanted side effects for other clients.