Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bigquery examples: update snippets to use preferred form of delete(). #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shollyman merged 2 commits into from
May 24, 2019
Merged

bigquery examples: update snippets to use preferred form of delete(). #5220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39ff8aa
bigquery examples: update snippets to use preferred form of delete().
shollyman May 24, 2019
7d25e8c
...and import
shollyman May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,8 @@ public boolean deleteDatasetFromId(String projectId, String datasetName) {
// [VARIABLE "my_table_name"]
public boolean deleteTable(String datasetName, String tableName) {
// [START ]
boolean deleted = bigquery.delete(datasetName, tableName);
TableId tableId = TableId.of(datasetName, tableName);
boolean deleted = bigquery.delete(tableId);
if (deleted) {
// the table was deleted
} else {
Expand Down
7 changes: 4 additions & 3 deletions ...examples/src/test/java/com/google/cloud/examples/bigquery/snippets/ITDatasetSnippets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import com.google.cloud.bigquery.Field;
import com.google.cloud.bigquery.StandardTableDefinition;
import com.google.cloud.bigquery.Table;
import com.google.cloud.bigquery.TableId;
import com.google.cloud.bigquery.testing.RemoteBigQueryHelper;
import java.util.Iterator;
import org.junit.AfterClass;
Expand Down Expand Up @@ -128,7 +129,7 @@ public void testListTablesNotEmpty() {
assertEquals(expectedTableName, actualTable.getTableId().getTable());
assertFalse(iterator.hasNext());

bigquery.delete(DATASET, expectedTableName);
bigquery.delete(TableId.of(DATASET, expectedTableName));
}

@Test
Expand All @@ -141,7 +142,7 @@ public void testGetTable() {
assertNotNull(actualTable);
assertEquals(expectedTableName, actualTable.getTableId().getTable());

bigquery.delete(DATASET, expectedTableName);
bigquery.delete(TableId.of(DATASET, expectedTableName));
}

@Test
Expand All @@ -157,6 +158,6 @@ public void testCreateTable() {
Field actualField = actualTable.getDefinition().getSchema().getFields().get(0);
assertEquals(expectedFieldName, actualField.getName());

bigquery.delete(DATASET, expectedTableName);
bigquery.delete(TableId.of(DATASET, expectedTableName));
}
}