Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Jun 20, 2019

Fixes #5518

@chingor13 Piper change will come soon.

@suztomo suztomo requested a review from a team as a code owner June 20, 2019 20:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 20, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 20, 2019
@chingor13 chingor13 self-assigned this Jun 20, 2019
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #5527 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5527   +/-   ##
=========================================
  Coverage     50.86%   50.86%           
  Complexity    24192    24192           
=========================================
  Files          2270     2270           
  Lines        230115   230115           
  Branches      25009    25009           
=========================================
  Hits         117041   117041           
  Misses       104436   104436           
  Partials       8638     8638

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7585ccd...09eb737. Read the comment docs.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 21, 2019
@suztomo
Copy link
Member Author

suztomo commented Jun 21, 2019

After #5530 is merged, I'll check this again.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@suztomo
Copy link
Member Author

suztomo commented Jun 21, 2019

"Merging master (351bee0)" was not included in the last Kokoro build (#4). Would you kick off Kokoro again?

@chingor13
Copy link
Contributor

Kokoro runs "as if merged", but we can retrigger again.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 21, 2019
@suztomo
Copy link
Member Author

suztomo commented Jun 21, 2019

Found expected message. This PR is ready for review and merge.

Snapshot versions have the same 106 errors as baseline

@@ -0,0 +1,34 @@
#!/bin/bash
# Copyright 2019 Google Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this should be Google LLC

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@suztomo
Copy link
Member Author

suztomo commented Jun 21, 2019

@chingor13 Would you merge this? (I don't have write access)

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@chingor13 chingor13 merged commit 86e223c into googleapis:master Jun 21, 2019
@JesseLovelace JesseLovelace mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply Linkage Monitor at presubmit build

5 participants