-
Notifications
You must be signed in to change notification settings - Fork 1.1k
BigQuery: Add routines support #5591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ff30d46
bigquery: add routines support
shollyman 7a4c364
working testing for basic standardsql types
shollyman e5f492d
RoutineArgument and test
shollyman 3dde407
plumbing plumbing plumbing
shollyman 964934f
most of the RPC layer, sans testing.
shollyman 3fb5094
switch standard sql types over to autovalues.
shollyman d4080ff
more testing, impls
shollyman 3dc662c
first working integration test
shollyman 3e2cb68
add ddlTargetRoutine (and missing enums). more testing.
shollyman c690d10
backout pom
shollyman 9158be3
Merge branch 'master' into routines
shollyman b321293
cleanup RoutineField enum
shollyman cc92f2d
add missing license headers, run code formatter
shollyman 7dbdb20
commenting pass.
shollyman 1387b02
more documentation and cleanup.
shollyman 0b3635f
more doc cleanup
shollyman 81ad33c
Merge branch 'master' into routines
shollyman d9a549d
address reviewer comments
shollyman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be package private? (Same with other public methods in package private classes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably reasonable, we extend Option but don't appear to extend each of the various typed options beyond that. Filed https://github.com/googleapis/google-cloud-java/issues/5728 to followup on visibility more generally.