Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bigtable: Fix stale docs #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorbernstein2 merged 1 commit into from
Jul 15, 2019
Merged

Bigtable: Fix stale docs #5742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google-cloud-clients/google-cloud-bigtable/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ import com.google.cloud.bigtable.data.v2.models.Row;
Then, to make a query to Bigtable, use the following code:
```java
// Instantiates a client
String projectId = "my-instance";
String instanceId = "my-database";
String projectId = "my-project";
String instanceId = "my-instance";
String tableId = "my-table";

// Create the client
Expand Down
11 changes: 6 additions & 5 deletions ...igtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableInstanceAdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,13 @@
* To customize the endpoint:
*
* <pre>{@code
* BigtableInstanceAdminSettings settings = BigtableInstanceAdminSettings.newBuilder()
* .setProjectId("my-project")
* .setEndpoint(myEndpoint)
* .build();
* BigtableInstanceAdminSettings.Builder settingsBuilder = BigtableInstanceAdminSettings.newBuilder()
* .setProjectId("my-project");
*
* BigtableInstanceAdminClient client = BigtableInstanceAdminClient.create(settings);
* settingsBuilder.stubSettings()
* .setEndpoint(myEndpoint);
*
* BigtableInstanceAdminClient client = BigtableInstanceAdminClient.create(settingsBuilder.build());
* }</pre>
*/
public final class BigtableInstanceAdminClient implements AutoCloseable {
Expand Down
8 changes: 5 additions & 3 deletions ...d-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,14 @@
* To customize the endpoint:
*
* <pre>{@code
* BigtableTableAdminSettings tableAdminSettings = BigtableTableAdminSettings.newBuilder()
* BigtableTableAdminSettings.Builder tableAdminSettingsBuilder = BigtableTableAdminSettings.newBuilder()
* .setProjectId("[PROJECT]")
* .setInstanceId("[INSTANCE]")
* .setInstanceId("[INSTANCE]");
*
* tableAdminSettingsBuilder.stubSettings()
* .setEndpoint(myEndpoint).build();
*
* BigtableTableAdminClient client = BigtableTableAdminClient.create(tableAdminSettings);
* BigtableTableAdminClient client = BigtableTableAdminClient.create(tableAdminSettingsBuilder.build());
* }</pre>
*/
public final class BigtableTableAdminClient implements AutoCloseable {
Expand Down
9 changes: 6 additions & 3 deletions ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,15 @@
* To customize the endpoint:
*
* <pre>{@code
* BigtableDataSettings bigtableDataSettings =
* BigtableDataSettings.Builder bigtableDataSettingsBuilder =
* BigtableDataSettings.newBuilder()
* .setProjectId("[PROJECT]")
* .setInstanceId("[INSTANCE]")
* .setInstanceId("[INSTANCE]");
*
* bigtableDataSettingsBuilder.stubSettings()
* .setEndpoint(myEndpoint).build();
* try(BigtableDataClient bigtableDataClient = BigtableDataClient.create(bigtableDataSettings)) {
*
* try(BigtableDataClient bigtableDataClient = BigtableDataClient.create(bigtableDataSettingsBuilder.build())) {
* // ..
* }
* }</pre>
Expand Down