Bigtable: Add ability to run tests against direct path #5756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reorganize failsafe config to have a separate execution for each test integration test target * Move each test integration target into it's own profile (keeping the emulator tests on by default) * Fork the ProdEnv for direct path environment
Author
|
This is currently broken because of The bigtable gapic yaml needs to be updated with correct rpc timeouts. I have a CL out that fixes all of the RPC timeouts, but can't be merged until googleapis/gapic-generator#2878 is merged |
Codecov Report
@@ Coverage Diff @@
## master #5756 +/- ##
============================================
+ Coverage 47.17% 47.17% +<.01%
Complexity 25130 25130
============================================
Files 2389 2389
Lines 259836 259836
Branches 29417 29417
============================================
+ Hits 122585 122586 +1
+ Misses 128321 128320 -1
Partials 8930 8930
Continue to review full report at Codecov.
|
kolea2
previously requested changes
Jul 18, 2019
...gle-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/env/DirectPathEnv.java
Show resolved
Hide resolved
...gle-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/env/DirectPathEnv.java
Outdated
Show resolved
Hide resolved
...bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java
Show resolved
Hide resolved
Author
|
Looks like emulator tests are failing because cbt emulator doesn't exist in kokoro. |
chingor13
approved these changes
Jul 19, 2019
igorbernstein2
added a commit
to igorbernstein2/google-cloud-java
that referenced
this pull request
Aug 1, 2019
This was a bug introduced in googleapis#5756. When integration profiles were introduced, I forgot to remove the test from the default execution of the failsafe plugin. The new way integration tests are run are via profile activation: by default the bigtable-emulator-it profile is active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: please review #5762 first. This PR includes changes from there
Please note that the directpath tests are not enabled in kokoro yet