Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bigtable: Update integration tests to use the bundled emulator #5769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorbernstein2 merged 2 commits into from
Jul 19, 2019
Merged

Bigtable: Update integration tests to use the bundled emulator #5769

igorbernstein2 merged 2 commits into from
Jul 19, 2019

Conversation

@igorbernstein2
Copy link

@igorbernstein2 igorbernstein2 commented Jul 18, 2019

Also update the emulator bundler to download artifacts in parallel

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

@igorbernstein2
Bigtable: Update integration tests to use the bundled emulator
13fb855 
Also update the emulator bundler to download artifacts in parallel
@igorbernstein2 igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Jul 18, 2019
@igorbernstein2 igorbernstein2 requested a review from kolea2 July 18, 2019 21:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2019
@igorbernstein2 igorbernstein2 mentioned this pull request Jul 18, 2019
Merged
@codecov
Copy link

codecov bot commented Jul 18, 2019 •
edited
Loading

Codecov Report

Merging #5769 into master will increase coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5769      +/-   ##
============================================
+ Coverage      46.5%   47.17%   +0.67%     
- Complexity    23679    25115    +1436     
============================================
  Files          2389     2389              
  Lines        254581   259836    +5255     
  Branches      28482    29422     +940     
============================================
+ Hits         118385   122586    +4201     
- Misses       127412   128320     +908     
- Partials       8784     8930     +146
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/com/google/cloud/BaseService.java 55.55% <0%> (-6.95%) 2% <0%> (ø)
...re/src/main/java/com/google/cloud/RetryHelper.java 50% <0%> (-3.85%) 2% <0%> (ø)
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...m/google/cloud/tasks/v2beta3/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
...va/com/google/cloud/tasks/v2/CloudTasksClient.java 57.43% <0%> (-2.68%) 67% <0%> (+16%)
...m/google/cloud/tasks/v2beta2/CloudTasksClient.java 57.14% <0%> (-2.39%) 79% <0%> (+19%)
...oogle/cloud/firestore/v1/FirestoreAdminClient.java 59.84% <0%> (-2.23%) 38% <0%> (+8%)
.../cloud/scheduler/v1beta1/CloudSchedulerClient.java 55% <0%> (-2.15%) 35% <0%> (+8%)
...oogle/cloud/scheduler/v1/CloudSchedulerClient.java 55% <0%> (-2.15%) 35% <0%> (+8%)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 89.58% <0%> (-1.91%) 32% <0%> (ø)
... and 646 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187fd3d...6ec8452. Read the comment docs.

kolea2
kolea2 reviewed Jul 19, 2019
View reviewed changes
TESTING.md
target environment can be selected via the `bigtable.env` system property. By default it is set to
`emulator` and the other option is `prod`.

To use the `emulator` environment, please install the gcloud sdk and use it to install the
Copy link
Contributor

@kolea2 kolea2 Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add these instructions to the emulator package?

Copy link
Author

@igorbernstein2 igorbernstein2 Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, these instructions are for running the tests. The emulator package has instructions focusing on how a customer can use the emulator for their own tests:

https://github.com/googleapis/google-cloud-java/tree/master/google-cloud-testing/google-cloud-bigtable-emulator

@igorbernstein2
Copy link
Author

igorbernstein2 commented Jul 19, 2019

Thanks for reviewing!

@igorbernstein2 igorbernstein2 merged commit 4a95f17 into googleapis:master Jul 19, 2019
@igorbernstein2 igorbernstein2 deleted the bundled-emulator branch July 19, 2019 03:16
@chingor13 chingor13 mentioned this pull request Jul 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2 @kolea2 @googlebot