Bigtable: update retry & timeout settings #5794
Conversation
Regenerate the client using the updated gapic settings: googleapis/googleapis@184ab77 And the updated gapic-generator: googleapis/gapic-generator#2878 Update the javadocs for the new settings Re-enable the dropRowRange integration test now that the settings are correct
This reverts commit 6f5d8f3.
Codecov Report
@@ Coverage Diff @@
## master #5794 +/- ##
============================================
+ Coverage 46.78% 46.79% +0.01%
Complexity 25648 25648
============================================
Files 2456 2456
Lines 267507 267593 +86
Branches 30564 30564
============================================
+ Hits 125142 125229 +87
+ Misses 133106 133105 -1
Partials 9259 9259
Continue to review full report at Codecov.
|
...src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStubSettings.java
Show resolved
Hide resolved
...src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStubSettings.java
Show resolved
Hide resolved
| settings = | ||
| RetrySettings.newBuilder() | ||
| .setInitialRetryDelay(Duration.ofMillis(5L)) | ||
| .setInitialRetryDelay(Duration.ofMillis(1000L)) |
There was a problem hiding this comment.
Duration.ofSeconds(1) is easier to read
There was a problem hiding this comment.
This code is autogenerated by gapic-generator. So it would have to change in its templates
...src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStubSettings.java
Show resolved
Hide resolved
...src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStubSettings.java
Show resolved
Hide resolved
...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableStubSettings.java
Show resolved
Hide resolved
|
@elharo thanks for the review, unfortunately I can't address any of the feedback because all of the java is autogenerated and I don't have control over it. The only thing thats handwritten here is javadoc in EnhancedBigtableStubSettings.java and the removal of PTAL |
elharo
left a comment
There was a problem hiding this comment.
I'm not intimately familiar with GAPIC but it sounds like something much deeper is wrong here. The general principle is that auto-generated code should not be checked into the repo. That's sort of like checking in .class files while the .java files only live on the developer's workstation. Another example: check in the .proto files, not the Java code the proto compiler generates. Only the actual editable source, in whatever form it takes, should be in the repository.
If the source generator is only used to initialize the source code, which is then hand edited as usual, then you can check in the generated code because it is in editable form, but it sounds like that is not the case here.
Regenerate the client using the updated gapic settings:
googleapis/googleapis@184ab77
And the updated gapic-generator:
googleapis/gapic-generator#2878
Update the javadocs for the new settings
Re-enable the dropRowRange integration test now that the settings are correct
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)