spanner-jdbc: Step 03 - Generic connection interface #5807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
reviewed
Jul 23, 2019
| * @return a string representation of this {@link AutocommitDmlMode} that can be used in a SQL | ||
| * statement. | ||
| */ | ||
| public String statementString() { |
Contributor
There was a problem hiding this comment.
can we change to getStatementString?
Author
There was a problem hiding this comment.
Changed to getStatementString
9c483d1 to
438f8e6
Compare
Codecov Report
@@ Coverage Diff @@
## spanner-jdbc #5807 +/- ##
==================================================
+ Coverage 46.12% 46.12% +<.01%
Complexity 24189 24189
==================================================
Files 2456 2456
Lines 262236 262236
Branches 29602 29602
==================================================
+ Hits 120949 120959 +10
+ Misses 132175 132166 -9
+ Partials 9112 9111 -1
Continue to review full report at Codecov.
|
kolea2
approved these changes
Jul 24, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
* create jdbc project * added spanner-jdbc to versions * add interfaces for client side statements * changed prerequisiteStatements to examplePrequisiteStatements * add generic connection interface * changed to normal getter name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JDBC driver is built on top of a generic connection based API. This PR adds the interface for this generic API. The interface itself is package-private, as it is not intended for end users. The
TransactionRetryListenerinterface is public, as these listeners can also be added for a JDBC connection.