spanner-jdbc: Step 06 - Client side statement parser #5814
Conversation
| } | ||
|
|
||
| private Mode parseMode(String name) { | ||
| for (Mode mode : Mode.values()) { |
There was a problem hiding this comment.
can we make this a Set lookup instead?
There was a problem hiding this comment.
Changed to a case-insensitive map.
|
|
||
| @Override | ||
| public AutocommitDmlMode convert(String value) { | ||
| for (AutocommitDmlMode mode : AutocommitDmlMode.values()) { |
There was a problem hiding this comment.
same question for this and the below for loops
There was a problem hiding this comment.
Changed to a case-insensitive map.
| String[] tokens = sql.split("\\s+", 2); | ||
| if (tokens.length > 0) { | ||
| for (String check : checkStatements) { | ||
| if (tokens[0].equalsIgnoreCase(check)) { |
There was a problem hiding this comment.
can this be simplified to sql.startsWith(check) (handling upper and lower case)?
There was a problem hiding this comment.
Not really (at least not with the goal of simplifying). The problems with that is that we need a regular expression check for all types of spaces (space, tab, enter, ...), as any type of space character is allowed as a separator between for example CREATE and TABLE. The nice thing with the String#split(String, int) method is that it stops searching after finding the requested matches. String.startsWith(String) does not support regular expressions.
| } | ||
|
|
||
| /** The name of this statement. Used in error and info messages. */ | ||
| private String name; |
There was a problem hiding this comment.
minor - can address later - we should clean up the whitespace here between variable declarations and javadoc
34ac7a9 to
aa123e1
Compare
I think your request crossed with my actual rebase :-) |
| } | ||
| } | ||
|
|
||
| private final List<String> ddlStatements = Arrays.asList("CREATE", "DROP", "ALTER"); |
There was a problem hiding this comment.
minor, can address later - I would change these to sets
* add client side statement parser * changed loops to a map lookup * fixed spacing between variables and javadoc * merge with spanner-jdbc * changed lists to sets
Adds the client side statement parser for statements that are interpreted and executed by the client instead of being sent to Cloud Spanner. Note:
ClientSideStatements.jsonare not directly related to this change, but theClientSideStatementValueConverterimplementations were moved from one file to another by one of the previous changes, and I forgot to change that in the .json file.ConnectionImplthat has not yet been added.