spanner-jdbc: Step 07 - DirectExecuteResultSet #5815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## spanner-jdbc #5815 +/- ##
==================================================
+ Coverage 46.12% 46.12% +<.01%
Complexity 24189 24189
==================================================
Files 2456 2456
Lines 262236 262236
Branches 29602 29602
==================================================
+ Hits 120949 120952 +3
+ Misses 132175 132173 -2
+ Partials 9112 9111 -1
Continue to review full report at Codecov.
|
kolea2
suggested changes
Jul 24, 2019
| try { | ||
| if (method.getParameterTypes().length == 0) { | ||
| method.invoke(subject); | ||
| } else if (method.getParameterTypes().length == 1 |
Contributor
There was a problem hiding this comment.
minor - for readability, can we extract some of these out into descriptive variables?
Author
There was a problem hiding this comment.
Number of parameters and parameter type have been extracted to variables and the if-statement has been partially re-written as a switch statement.
kolea2
approved these changes
Jul 25, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
* add DirectExecuteResultSet * readability: extracted numberOfParameters and firstParameterType to vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Cloud Spanner
ResultSetimplementation defers the execution of a query to the first call toResultSet#next(). The JDBC Driver requires that queries are executed directly when a statement is passed to the driver, and that any query errors are returned directly. TheDirectExecuteResultSetis a wrapper around a normal result set that ensures that the query is executed directly, and that any query errors are propagated directly when the result set is created, instead of deferring this until the first call toResultSet#next().