spanner-jdbc: Step 08 - ReplaceableForwardingResultSet #5816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
suggested changes
Jul 24, 2019
| @@ -0,0 +1,294 @@ | |||
| /* | |||
| * Copyright 2018 Google LLC | |||
| try (ReplaceableForwardingResultSet subject = new ReplaceableForwardingResultSet(delegate)) { | ||
| subject.next(); | ||
|
|
||
| subject.getBoolean(0); |
Contributor
There was a problem hiding this comment.
I'd make a note somewhere in the above implementation that column indexes start at 0
Author
There was a problem hiding this comment.
I added a note about this in the test case, as I assume that you mean that. In the class itself (ReplaceableForwardingResultSet), it is clear from the interface it is implementing that column indices are zero-based.
kolea2
approved these changes
Jul 25, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
* add ReplaceableForwardingResultSet * fixed CR year * added note for zero-based column indices + added vars for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JDBC Driver contains an internal retry algorithm for aborted read/write transactions that rely on keeping track of a SHA-256 checksum for all data that is returned by Cloud Spanner. When a transaction is successfully retried, all open result sets must be replaced with a fresh one that is linked with the new transaction. This is achieved by returning result sets to the user that contain a delegate that may be replaced by the JDBC Driver at a later moment.