spanner-jdbc: Step 09 - StatementResultImpl #5847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
suggested changes
Jul 24, 2019
| * one STRING column containing an {@link Enum} value and one row that is created by a {@link | ||
| * ClientSideStatement}. | ||
| */ | ||
| static StatementResult resultSet( |
Contributor
There was a problem hiding this comment.
do we need more tests here for all the different types?
Author
There was a problem hiding this comment.
I've added test cases for all the missing convenience methods.
kolea2
approved these changes
Jul 25, 2019
Codecov Report
@@ Coverage Diff @@
## spanner-jdbc #5847 +/- ##
==================================================
- Coverage 46.12% 46.12% -0.01%
+ Complexity 24189 24187 -2
==================================================
Files 2456 2456
Lines 262236 262236
Branches 29602 29602
==================================================
- Hits 120949 120947 -2
- Misses 132175 132176 +1
- Partials 9112 9113 +1
Continue to review full report at Codecov.
|
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
* add StatementResultImpl * added missing test cases for convenience methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation for
StatementResult.StatementResultis a wrapper around the result returned by a generic statement that is executed by the JDBC Driver. It can contain:ResultSetreturned by a query on Cloud Spanner, or aResultSetreturned by a client side statement (e.g.SHOW VARIABLE AUTOCOMMIT).SET <VARIABLE_NAME> = <VALUE>type client side statements also do not return any results.