spanner-jdbc: Step 14 - Add base interface for unit of work on connections #5881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
suggested changes
Jul 25, 2019
| import com.google.cloud.spanner.ReadContext.QueryAnalyzeMode; | ||
|
|
||
| /** | ||
| * {@link AnalyzeMode} indicates whether a query should be executed as a normal query, whether only |
Contributor
There was a problem hiding this comment.
would add "as a normal query (NONE)..."
| ParsedStatement statement, AnalyzeMode analyzeMode, QueryOption... options); | ||
|
|
||
| /** | ||
| * @return the read timestamp of this transaction. Will throw an {@link SpannerException} if there |
Contributor
There was a problem hiding this comment.
minor - "Will throw a" instead of "an"
Codecov Report
@@ Coverage Diff @@
## spanner-jdbc #5881 +/- ##
==================================================
+ Coverage 46.12% 46.12% +<.01%
- Complexity 24187 24189 +2
==================================================
Files 2456 2456
Lines 262236 262236
Branches 29602 29602
==================================================
+ Hits 120947 120952 +5
+ Misses 132176 132173 -3
+ Partials 9113 9111 -2
Continue to review full report at Codecov.
|
kolea2
approved these changes
Jul 26, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
…tions (googleapis#5881) add base interface for unit of work on connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A connection can execute several different types of transactions and batches (DML/DDL). These all implement the base interface
UnitOfWork.