spanner-jdbc: Step 17 - Base class for transactions and batches #5894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
reviewed
Jul 26, 2019
| @@ -0,0 +1,159 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
Any tests we should be adding here? Or will be in future commits?
Author
There was a problem hiding this comment.
The tests for both this abstract base class as well as much of the concrete subclasses are handled by the SQL based unit tests. I will add these through separate PRs, as they need the whole stack of connection and transactions to be present to work.
kolea2
approved these changes
Jul 29, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the abstract base implementation for all transactions and batches that can be executed on a connection, and the executor that is used for executing statements on a connection.
(This PR will have build errors until 15 has been merged)