spanner-jdbc: Step 18 - ConnectionImpl #5895
Conversation
| @Override | ||
| public Thread newThread(Runnable r) { | ||
| Thread t = new Thread(r); | ||
| t.setDaemon(true); |
There was a problem hiding this comment.
Should we also add a qualifying name?
| this.spannerPool = SpannerPool.INSTANCE; | ||
| this.options = options; | ||
| this.spanner = spannerPool.getSpanner(options, this); | ||
| this.ddlClient = DdlClient.newBuilder().setDatabaseAdminClient(spanner.getDatabaseAdminClient()) |
There was a problem hiding this comment.
I'd move this logic to a private method, createDdlClient
There was a problem hiding this comment.
Moved to a separate method, and moved the assignment to the end of the constructor to ensure that all fields have been initialized.
| } | ||
|
|
||
| @Override | ||
| public StatementResult statementSetAutocommit(Boolean autocommit) { |
There was a problem hiding this comment.
should autocommit be autoCommit? WDYT?
There was a problem hiding this comment.
(not sure if this is an already defined naming convention elsewhere)
There was a problem hiding this comment.
Both are used. I have a slight preference for autocommit, but I don't feel very strongly about this.
JDBC uses autoCommit. SQL Server uses auto-commit. PostgreSQL and MySQL use autocommit in their documentation.
There was a problem hiding this comment.
One reason to keep this as autocommit is that we have defined the variable AUTOCOMMIT_DML_MODE, which indicates that the driver assumes autocommit to be one word.
7fbf46a to
fababa6
Compare
* add ConnectionImpl * fix CR year * moved DdlClient creation to separate method * updated changed class reference
Adds the implementation class of the internal Spanner connection API. JDBC connections act as wrappers around this class. A ConnectionImpl instance is used to interact with Cloud Spanner through several different types of transactions or batches. There can be at most one transaction or batch active at any one time on a connection.
This PR will have build errors as it depends on step 15 (ConnectionOptions), but also on the different types of transaction classes that will be brought in through separate PRs.