spanner-jdbc: Step 22 - DdlBatch #5907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
suggested changes
Jul 29, 2019
...-contrib/google-cloud-spanner-jdbc/src/main/java/com/google/cloud/spanner/jdbc/DdlBatch.java
Outdated
Show resolved
Hide resolved
...trib/google-cloud-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/DdlBatchTest.java
Show resolved
Hide resolved
95c3551 to
0ded7c8
Compare
kolea2
suggested changes
Jul 30, 2019
| // Return metadata. | ||
| return operation.getMetadata().get(); | ||
| } catch (Exception e) { | ||
| UpdateDatabaseDdlMetadata metadata = operation.getMetadata().get(); |
Contributor
There was a problem hiding this comment.
let's extract into a private method - computeUpdateCounts?
kolea2
approved these changes
Jul 30, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
* add DdlBatch * return successful/failed DDL statements * extracted update count extraction to a separate method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DdlBatch. A DdlBatch can be used to execute a set of DDL statements as one batch. A DDL batch is not atomic, and it could be that only some of the statements will succeed. DdlBatch is implemented as a
UnitOfWorkon a connection, and there can only be oneUnitOfWorkactive at any time on a connection. This means that when a connection is executing a DDL batch, it will not be executing any other transaction, and only DDL statements are allowed.A DDL batch can be executed both through calling specific methods on a connection instance, as well as by using the auxiliary SQL statements
START BATCH DDLandRUN BATCH/ABORT BATCH.