spanner-jdbc: Step 24 - Parameter store for jdbc parameters #5909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
suggested changes
Jul 29, 2019
...e-cloud-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/JdbcParameterStoreTest.java
Show resolved
Hide resolved
413cf9a to
8c10642
Compare
kolea2
suggested changes
Jul 30, 2019
| is(equalTo(JdbcArray.createArray("INT64", new Long[] {1L, 2L, 3L})))); | ||
| verifyParameter(params, Value.int64Array(new long[] {1, 2, 3})); | ||
|
|
||
| params.setParameter(1, JdbcArray.createArray("FLOAT64", new Double[] {1D, 2D, 3D}), |
Contributor
There was a problem hiding this comment.
can we add in some additional test cases with null values?
Author
There was a problem hiding this comment.
Added tests with null values in the array, as well as setting a null value as an array parameter.
kolea2
approved these changes
Jul 30, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
…is#5909) * add parameter store for jdbc parameters * add null check * added additional test statements * added tests for null values in array and null-array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a generic data store for JDBC parameters. JDBC parameters are position based, and can be set in any order. They are therefore stored in an ArrayList that may contain null values for parameters that have not yet been set.