spanner-jdbc: Step 25 - JdbcConnection implementation #5910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
suggested changes
Jul 29, 2019
...e-cloud-spanner-jdbc/src/main/java/com/google/cloud/spanner/jdbc/AbstractJdbcConnection.java
Outdated
Show resolved
Hide resolved
26c618f to
561b1dc
Compare
kolea2
approved these changes
Jul 30, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
* add jdbc connection implementation * update CR year * add warnings for ClientInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation for
CloudSpannerJdbcConnection.There are some basic tests in
JdbcConnectionTest. The main testing is done by the SQL based tests that will be added once all main code has been merged.