spanner-jdbc: Step 26 - JDBC Statement and PreparedStatement implementation #5911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
suggested changes
Jul 29, 2019
| } | ||
|
|
||
| @Override | ||
| public void setBoolean(int parameterIndex, boolean x) throws SQLException { |
Contributor
There was a problem hiding this comment.
minor - please rename all x variables - value maybe?
Author
There was a problem hiding this comment.
x variables have been renamed to value.
| } | ||
|
|
||
| @Override | ||
| public ResultSetMetaData getMetaData() throws SQLException { |
| } | ||
|
|
||
| @Override | ||
| public ResultSet getGeneratedKeys() throws SQLException { |
03c7264 to
75588f2
Compare
kolea2
approved these changes
Jul 30, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
…tation (googleapis#5911) * add jdbc Statement and PreparedStatement implementation * updated CR year * return successful/failed ddl statements * changed variable names from x to value * added missing test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementations for java.sql.Statement and java.sql.PreparedStatements. The most important task for these classes is to convert positional JDBC parameters to Cloud Spanner named parameters.