spanner-jdbc: Step 27 - JdbcDriver #5912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
suggested changes
Jul 29, 2019
...ib/google-cloud-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/JdbcDriverTest.java
Outdated
Show resolved
Hide resolved
...cloud-contrib/google-cloud-spanner-jdbc/src/main/resources/META-INF/services/java.sql.Driver
Show resolved
Hide resolved
68038e2 to
0dd1027
Compare
kolea2
reviewed
Jul 30, 2019
...ib/google-cloud-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/JdbcDriverTest.java
Show resolved
Hide resolved
kolea2
reviewed
Jul 30, 2019
| } | ||
| private static JdbcDriver registeredDriver; | ||
|
|
||
| static void register() throws SQLException { |
Contributor
There was a problem hiding this comment.
Sorry, one last question. How come this is different than the class loading done in JdbcDataSource?
Author
There was a problem hiding this comment.
The JdbcDataSource is not responsible for registering the JDBC driver. That is the responsibility of the driver itself, and is done automatically when the driver class (JdbcDriver) is loaded. In most newer environments this is done automatically thanks to the service registration in META-INF/services/java.sqlDriver. The JdbcDataSource does a manual load of the driver class to be 100% certain that the driver is loaded and registered, although in most cases it will be redundant.
kolea2
approved these changes
Jul 30, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
* add JdbcDriver * add jdbc DataSource implementation * removed information from test connection url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the actual JDBC Driver, including the service registration file for the driver.