spanner-jdbc: Step 28 - JdbcDatabaseMetadata #5913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
suggested changes
Jul 29, 2019
...gle-cloud-spanner-jdbc/src/main/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
9113879 to
013a3f5
Compare
kolea2
reviewed
Jul 30, 2019
| } | ||
|
|
||
| @Override | ||
| public ResultSet getSchemas(String catalog, String schemaPattern) throws SQLException { |
Contributor
There was a problem hiding this comment.
do we have tests for this (and the other sql query methods)?
Author
There was a problem hiding this comment.
Yes, but they are created as integration tests (ITJdbcDatabaseMetaDataTest in the private repo), so they will be added in a later PR.
kolea2
approved these changes
Jul 30, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
* add JdbcDatabaseMetadata * added implementation for getUserName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds JDBC database metadata.