spanner-jdbc-cleanup - Step 05 - Add missing test cases #5953
Conversation
|
Will review after rebase :) |
Aborted transactions were not handled correctly by the executeUpdate and batchUpdate methods when used in combination with a TransactionManager. If the user would try to reset the transaction for retry after such an abort, the TransactionManager would throw an IllegalStateException, because it did not know that the transaction had actually aborted. Fixes googleapis#5951
a166f12 to
337834b
Compare
Done rebasing, and I cherry-picked the fix for #5951 into this PR in order to prevent the |
kolea2
left a comment
There was a problem hiding this comment.
LGTM after copyright year updates and taking stress tests out of this PR.
| @@ -0,0 +1,110 @@ | |||
| /* | |||
| * Copyright 2018 Google LLC | |||
| @@ -0,0 +1,183 @@ | |||
| /* | |||
| * Copyright 2018 Google LLC | |||
| @@ -0,0 +1,155 @@ | |||
| /* | |||
| * Copyright 2018 Google LLC | |||
| @@ -0,0 +1,66 @@ | |||
| /* | |||
| * Copyright 2018 Google LLC | |||
| @@ -0,0 +1,180 @@ | |||
| /* | |||
| * Copyright 2018 Google LLC | |||
| @@ -0,0 +1,69 @@ | |||
| /* | |||
| * Copyright 2018 Google LLC | |||
| @@ -0,0 +1,961 @@ | |||
| /* | |||
| * Copyright 2018 Google LLC | |||
| @@ -0,0 +1,548 @@ | |||
| /* | |||
There was a problem hiding this comment.
This is great, but I don't think this is the appropriate place to put this type of test alongside other JUnit tests. For example, we have a different module for our conformance tests - not sure if we should think about a new module for stress testing.
That said, can we move this to a future PR after we think about it some more?
|
Removed stress tests and updated copyright years. Note that the stress tests were not executed alongside with the unit tests, as they were added to a test group that was excluded from normal test execution. If we want to add these back to the library, we should also add this exclusion again to prevent test execution from taking too much time. |
) * move remaining unit tests into public repo * handle aborted transactions when using TransactionManager Aborted transactions were not handled correctly by the executeUpdate and batchUpdate methods when used in combination with a TransactionManager. If the user would try to reset the transaction for retry after such an abort, the TransactionManager would throw an IllegalStateException, because it did not know that the transaction had actually aborted. Fixes googleapis#5951 * update CR years * removed stress tests
Adds miscellaneous unit tests that had not yet been merged in.
Two test cases in the
JdbcAbortedTransactionTestwill fail until #5952 has been merged.