Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move setClientLibToken to ServiceOptions. #5959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olavloite merged 3 commits into from
Aug 5, 2019
Merged

Move setClientLibToken to ServiceOptions. #5959

olavloite merged 3 commits into from
Aug 5, 2019

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented Aug 1, 2019

After discussion with @chingor13, moving this API to ServiceOptions to use more broadly.

@kolea2 kolea2 requested review from chingor13 and olavloite August 1, 2019 21:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2019
@chingor13
Copy link
Contributor

chingor13 commented Aug 1, 2019

cc @dazuma

@codecov
Copy link

codecov bot commented Aug 1, 2019 •
edited
Loading

Codecov Report

Merging #5959 into spanner-jdbc will decrease coverage by 0.77%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             spanner-jdbc    #5959      +/-   ##
==================================================
- Coverage           47.33%   46.56%   -0.78%     
+ Complexity          27091    25581    -1510     
==================================================
  Files                2516     2516              
  Lines              273453   268014    -5439     
  Branches            31350    30337    -1013     
==================================================
- Hits               129442   124798    -4644     
+ Misses             134405   133763     -642     
+ Partials             9606     9453     -153
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/ServiceOptions.java 40.33% <33.33%> (+0.07%) 29 <0> (ø) ⬇️
...va/com/google/cloud/spanner/jdbc/FailedUpdate.java 0% <0%> (-86.37%) 0% <0%> (-2%)
...m/google/cloud/spanner/jdbc/ChecksumResultSet.java 37.73% <0%> (-52.21%) 4% <0%> (-4%)
...ava/com/google/cloud/spanner/jdbc/FailedQuery.java 0% <0%> (-37.04%) 0% <0%> (-1%)
...oogle/cloud/spanner/jdbc/RetriableBatchUpdate.java 0% <0%> (-35%) 0% <0%> (-1%)
...m/google/cloud/spanner/jdbc/FailedBatchUpdate.java 0% <0%> (-29.63%) 0% <0%> (-1%)
...oogle/cloud/spanner/jdbc/ReadWriteTransaction.java 52.54% <0%> (-27.12%) 36% <0%> (-15%)
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 68.18% <0%> (-18.7%) 34% <0%> (-5%)
...le/cloud/spanner/jdbc/JdbcSqlExceptionFactory.java 31.88% <0%> (-13.84%) 5% <0%> (-2%)
...com/google/cloud/spanner/jdbc/RetriableUpdate.java 80% <0%> (-10%) 3% <0%> (ø)
... and 852 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1905f8...c97de8d. Read the comment docs.

@olavloite olavloite merged commit b4ef635 into googleapis:spanner-jdbc Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 left review comments

+1 more reviewer

@olavloite olavloite olavloite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kolea2 @chingor13 @olavloite @googlebot