spanner-jdbc-cleanup - Step 13 - Add integration tests for transactions and retries #6003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolea2
suggested changes
Aug 2, 2019
| } | ||
|
|
||
| @Test | ||
| public void testDoAllowBufferedWriteInReadWriteTransaction() { |
Contributor
There was a problem hiding this comment.
let's add some additional assertions to these to confirm the writes.
Author
There was a problem hiding this comment.
Added assertions that the writes were successful.
kolea2
approved these changes
Aug 5, 2019
olavloite
added a commit
to olavloite/google-cloud-java
that referenced
this pull request
Aug 5, 2019
…ns and retries (googleapis#6003) * add integration tests for transactions and retries * add assertions that the values are actually written
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration tests for transaction modes and transaction retries for the generic connection API.