Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bigtable: minor cleanups #6142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorbernstein2 merged 1 commit into from
Aug 23, 2019
Merged

Bigtable: minor cleanups #6142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ...d-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ public void close() {
* @see CreateTableRequest for available options.
* @see GCRules for the documentation on available garbage collection rules.
*/
@SuppressWarnings("WeakerAccess")
public Table createTable(CreateTableRequest request) {
return ApiExceptions.callAndTranslateApiException(createTableAsync(request));
}
Expand Down Expand Up @@ -266,7 +265,6 @@ public ApiFuture<Table> createTableAsync(CreateTableRequest request) {
*
* @see ModifyColumnFamiliesRequest for available options.
*/
@SuppressWarnings("WeakerAccess")
public Table modifyFamilies(ModifyColumnFamiliesRequest request) {
return ApiExceptions.callAndTranslateApiException(modifyFamiliesAsync(request));
}
Expand Down Expand Up @@ -335,7 +333,6 @@ public ApiFuture<Table> modifyFamiliesAsync(ModifyColumnFamiliesRequest request)
* client.deleteTable("my-table");
* }</pre>
*/
@SuppressWarnings("WeakerAccess")
public void deleteTable(String tableId) {
ApiExceptions.callAndTranslateApiException(deleteTableAsync(tableId));
}
Expand Down Expand Up @@ -457,7 +454,6 @@ public Boolean apply(NotFoundException ignored) {
* }
* }</pre>
*/
@SuppressWarnings("WeakerAccess")
public Table getTable(String tableId) {
return ApiExceptions.callAndTranslateApiException(getTableAsync(tableId));
}
Expand Down Expand Up @@ -514,7 +510,6 @@ private ApiFuture<Table> getTableAsync(
* }
* }</pre>
*/
@SuppressWarnings("WeakerAccess")
public List<String> listTables() {
return ApiExceptions.callAndTranslateApiException(listTablesAsync());
}
Expand Down Expand Up @@ -545,7 +540,6 @@ public List<String> listTables() {
* );
* }</pre>
*/
@SuppressWarnings("WeakerAccess")
public ApiFuture<List<String>> listTablesAsync() {
ListTablesRequest request =
ListTablesRequest.newBuilder()
Expand Down Expand Up @@ -619,7 +613,6 @@ public List<String> apply(List<com.google.bigtable.admin.v2.Table> protos) {
* client.dropRowRange("my-table", "prefix");
* }</pre>
*/
@SuppressWarnings("WeakerAccess")
public void dropRowRange(String tableId, String rowKeyPrefix) {
ApiExceptions.callAndTranslateApiException(dropRowRangeAsync(tableId, rowKeyPrefix));
}
Expand Down Expand Up @@ -715,7 +708,6 @@ public ApiFuture<Void> dropRowRangeAsync(String tableId, ByteString rowKeyPrefix
* client.dropAllRows("my-table");
* }</pre>
*/
@SuppressWarnings("WeakerAccess")
public void dropAllRows(String tableId) {
ApiExceptions.callAndTranslateApiException(dropAllRowsAsync(tableId));
}
Expand Down Expand Up @@ -767,7 +759,6 @@ public ApiFuture<Void> dropAllRowsAsync(String tableId) {
*
* @throws com.google.api.gax.retrying.PollException when polling exceeds the total timeout
*/
@SuppressWarnings("WeakerAccess")
public void awaitReplication(String tableId) {
// TODO(igorbernstein2): remove usage of typesafe names
com.google.bigtable.admin.v2.TableName tableName =
Expand Down
2 changes: 1 addition & 1 deletion ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,7 +1162,7 @@ public UnaryCallable<ReadModifyWriteRow, Row> readModifyWriteRowCallable() {

/** Close the clients and releases all associated resources. */
@Override
public void close() throws Exception {
public void close() {
stub.close();
}
}
2 changes: 1 addition & 1 deletion ...d-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ public UnaryCallable<ReadModifyWriteRow, Row> readModifyWriteRowCallable() {
// </editor-fold>

@Override
public void close() throws Exception {
public void close() {
stub.close();
}
}