Thanks to visit codestin.com
Credit goes to github.com

Skip to content

spanner-jdbc: Add additional tests for JdbcDatabaseMetaData #6154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olavloite merged 3 commits into from
Aug 26, 2019
Merged

spanner-jdbc: Add additional tests for JdbcDatabaseMetaData #6154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
680afe7
nullsAreSortedAtStart should be false
olavloite Aug 25, 2019
b3d9d3c
document how Cloud Spanner supports UNION
olavloite Aug 25, 2019
98a16ee
add missing trivial test cases
olavloite Aug 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...-cloud-spanner-jdbc/src/main/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public boolean nullsAreSortedLow() throws SQLException {

@Override
public boolean nullsAreSortedAtStart() throws SQLException {
return true;
return false;
}

@Override
Expand Down Expand Up @@ -502,6 +502,8 @@ public boolean supportsCorrelatedSubqueries() throws SQLException {

@Override
public boolean supportsUnion() throws SQLException {
// Note that Cloud Spanner requires the user to specify 'UNION DISTINCT' or 'UNION ALL' in a
// query. 'UNION DISTINCT' is equal to the SQL operation 'UNION'.
return true;
}

Expand Down
68 changes: 68 additions & 0 deletions ...ud-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaDataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import java.sql.ResultSetMetaData;
import java.sql.RowIdLifetime;
import java.sql.SQLException;
import java.sql.Types;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
Expand Down Expand Up @@ -61,6 +62,13 @@ public void testTrivialMethods() throws SQLException {
}) {
assertThat(meta.deletesAreDetected(type), is(false));
assertThat(meta.insertsAreDetected(type), is(false));
assertThat(meta.updatesAreDetected(type), is(false));
assertThat(meta.ownDeletesAreVisible(type), is(false));
assertThat(meta.ownInsertsAreVisible(type), is(false));
assertThat(meta.ownUpdatesAreVisible(type), is(false));
assertThat(meta.othersDeletesAreVisible(type), is(false));
assertThat(meta.othersInsertsAreVisible(type), is(false));
assertThat(meta.othersUpdatesAreVisible(type), is(false));
}
assertThat(meta.doesMaxRowSizeIncludeBlobs(), is(true));
assertThat(meta.generatedKeyAlwaysReturned(), is(false));
Expand All @@ -72,6 +80,8 @@ public void testTrivialMethods() throws SQLException {
assertThat(
meta.getDatabaseProductVersion(),
is(equalTo(DATABASE_MAJOR_VERSION + "." + DATABASE_MINOR_VERSION)));
assertThat(
meta.getDefaultTransactionIsolation(), is(equalTo(Connection.TRANSACTION_SERIALIZABLE)));
assertThat(meta.getDriverName(), is(equalTo("com.google.cloud.spanner.jdbc.JdbcDriver")));
assertThat(meta.getExtraNameCharacters(), is(equalTo("")));
assertThat(meta.getIdentifierQuoteString(), is(equalTo("`")));
Expand Down Expand Up @@ -104,6 +114,12 @@ public void testTrivialMethods() throws SQLException {
assertThat(meta.getSchemaTerm(), is(equalTo("SCHEMA")));
assertThat(meta.getSearchStringEscape(), is(equalTo("\\")));
assertThat(meta.getSQLStateType(), is(equalTo(DatabaseMetaData.sqlStateSQL)));
assertThat(meta.locatorsUpdateCopy(), is(true));
assertThat(meta.nullsAreSortedHigh(), is(false));
assertThat(meta.nullsAreSortedLow(), is(true));
assertThat(meta.nullsAreSortedAtStart(), is(false));
assertThat(meta.nullsAreSortedAtEnd(), is(false));
assertThat(meta.nullPlusNonNullIsNull(), is(true));
assertThat(meta.isCatalogAtStart(), is(false));
assertThat(meta.isReadOnly(), is(equalTo(connection.isReadOnly())));
assertThat(meta.storesLowerCaseIdentifiers(), is(false));
Expand All @@ -124,7 +140,54 @@ public void testTrivialMethods() throws SQLException {
assertThat(meta.supportsCatalogsInProcedureCalls(), is(false));
assertThat(meta.supportsCatalogsInTableDefinitions(), is(false));
assertThat(meta.supportsColumnAliasing(), is(true));
// Note that the supportsConvert() method indicates whether the server side function CONVERT is
// supported, not what the JDBC driver might be able to convert on the client side.
assertThat(meta.supportsConvert(), is(false));
int[] types =
new int[] {
Types.ARRAY,
Types.BIGINT,
Types.BINARY,
Types.BIT,
Types.BLOB,
Types.BOOLEAN,
Types.CHAR,
Types.CLOB,
Types.DATALINK,
Types.DATE,
Types.DECIMAL,
Types.DISTINCT,
Types.DOUBLE,
Types.FLOAT,
Types.INTEGER,
Types.JAVA_OBJECT,
Types.LONGNVARCHAR,
Types.LONGVARCHAR,
Types.LONGVARBINARY,
Types.LONGVARCHAR,
Types.NCHAR,
Types.NCLOB,
Types.NULL,
Types.NUMERIC,
Types.NVARCHAR,
Types.OTHER,
Types.REAL,
Types.REF,
Types.ROWID,
Types.SMALLINT,
Types.SQLXML,
Types.STRUCT,
Types.TIME,
Types.TIMESTAMP,
Types.TINYINT,
Types.VARBINARY,
Types.VARCHAR
};
for (int from : types) {
for (int to : types) {
assertThat(meta.supportsConvert(from, to), is(false));
}
}
assertThat(meta.supportsCoreSQLGrammar(), is(false));
assertThat(meta.supportsCorrelatedSubqueries(), is(true));
assertThat(meta.supportsDataDefinitionAndDataManipulationTransactions(), is(false));
Expand Down Expand Up @@ -186,6 +249,11 @@ public void testTrivialMethods() throws SQLException {
assertThat(meta.supportsSubqueriesInIns(), is(true));
assertThat(meta.supportsSubqueriesInQuantifieds(), is(true));
assertThat(meta.supportsTableCorrelationNames(), is(true));
assertThat(meta.supportsTransactions(), is(true));
assertThat(meta.supportsUnion(), is(true));
assertThat(meta.supportsUnionAll(), is(true));
assertThat(meta.usesLocalFiles(), is(false));
assertThat(meta.usesLocalFilePerTable(), is(false));
assertThat(
meta.supportsTransactionIsolationLevel(Connection.TRANSACTION_SERIALIZABLE), is(true));
for (int level :
Expand Down