Remove some custom settings in BQ storage client. #6519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes some custom settings from the "enhanced" stub settings for the BigQuery storage client which are now redundant, such as the maximum message size. The entire enhanced layer now exists only for the purpose of setting the resumption strategy for the ReadRows streaming callable.
shollyman
approved these changes
Oct 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #6519 +/- ##
============================================
- Coverage 46.35% 46.34% -0.01%
- Complexity 27995 27997 +2
============================================
Files 2613 2613
Lines 288066 288068 +2
Branches 33776 33778 +2
============================================
- Hits 133524 133519 -5
- Misses 144303 144309 +6
- Partials 10239 10240 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes some custom settings from the "enhanced" stub
settings for the BigQuery storage client which are now redundant, such
as the maximum message size. The entire enhanced layer now exists only
for the purpose of setting the resumption strategy for the ReadRows
streaming callable.