Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Fixing stuff and root_versions script #8774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddixit14 merged 1 commit into from
Nov 14, 2022
Merged

chore: Fixing stuff and root_versions script #8774

ddixit14 merged 1 commit into from
Nov 14, 2022

Conversation

@ddixit14
Copy link
Contributor

@ddixit14 ddixit14 commented Nov 14, 2022

This PR is doing three fixes:

  1. java-dns artifact was not getting updated in the release-pr (because google-cloud-dns artifact was not present in root versions.txt) so fixed it.
  2. java-kms pom.xml annotation was wrong for one artifact, fixed it.
  3. Fixed generate_root_versions_txt.sh because we no longer have versions.txt in each module, only the newly generated modules will have it. Now we need to run this only as a part of generating new-module.

@ddixit14 ddixit14 merged commit 6ca1f65 into main Nov 14, 2022
@ddixit14 ddixit14 deleted the monorepo-fix branch November 14, 2022 18:26
alicejli pushed a commit that referenced this pull request Nov 15, 2022
@ddixit14 @alicejli
chore: Fixing some stuff (#8774)
b8546e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo approved these changes

@meltsufin meltsufin Awaiting requested review from meltsufin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddixit14 @suztomo