chore: Manifest setup with single root component #8778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suztomo
approved these changes
Nov 14, 2022
Member
suztomo
left a comment
There was a problem hiding this comment.
Adding stamp but wait for Jeff
chingor13
approved these changes
Nov 14, 2022
| "component": "main" | ||
| } | ||
| }, | ||
| "plugins": ["maven-workspace"] |
Contributor
There was a problem hiding this comment.
You should skip this plugin if there's only a single component unless you have pom.xml files without annotations.
It shouldn't hurt but will make extra API calls and do extra work to build the dependency tree.
Contributor
Author
There was a problem hiding this comment.
@meltsufin, I remember you fixed all the pom.xml's to have the annotations. Should I remove this plugin then? or better to have it around for now?
Member
There was a problem hiding this comment.
All poms are fixed to have annotations and there is a check to verify it.
alicejli
pushed a commit
that referenced
this pull request
Nov 15, 2022
* chore: Manifest setup with single root component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.