[BC Break] Switch to standard SQL by default #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwsupplee
reviewed
Aug 18, 2017
Contributor
dwsupplee
left a comment
There was a problem hiding this comment.
It looks like the examples should be updated to use standard SQL, something like this should do the trick:
$queryResults = $bigQuery->runQuery('SELECT commit FROM `bigquery-public-data.github_repos.commits` LIMIT 100');Otherwise, LGTM! :)
src/BigQuery/BigQueryClient.php
Outdated
| * @type bool $useLegacySql Specifies whether to use BigQuery's legacy | ||
| * SQL dialect for this query. **Defaults to** `true`. If set to | ||
| * false, the query will use | ||
| * SQL dialect for this query. **Defaults to** `false`. Unless set to |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@dwsupplee updated |
dwsupplee
pushed a commit
to dwsupplee/gcloud-php
that referenced
this pull request
Oct 16, 2017
* Switch to standard SQL by default * Fix setting of useLegacySql option * Fix job config logic * Address code review
dwsupplee
added a commit
that referenced
this pull request
Oct 16, 2017
* Run query and wait for it to complete (#604) * Run query and wait for it to complete * Document exception on BigQueryClient::runQuery() * Update snippet test * Add support for etags on bigquery tables and datasets (#634) * [BC Break] Switch to standard SQL by default (#640) * Switch to standard SQL by default * Fix setting of useLegacySql option * Fix job config logic * Address code review * [BC Break] Implement waitUntilComplete and block while waiting for query results (#642) * implement waitUntilComplete on job and block waiting for queryResults * fix getIterator docblock * Generate BigQuery Job ID on client side with optional prefix (#643) * address code review * Introduce remaining BigQuery to GA items (#686) * introduce job configuration classes * update tests/docs and add copy/load * modify retry logic * add create on insert logic
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.