Implement automatic downsizing of session pool #646
Conversation
| */ | ||
| public function deleteSessionAsync(array $args) | ||
| { | ||
| $database = $this->pluck('database', $args); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/Spanner/V1/SpannerClient.php
Outdated
| { | ||
| // This class is intentionally empty, and is intended to hold manual additions to the generated {@see SpannerClientImpl} class. | ||
| /** | ||
| * Returns the underyling stub. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
|
|
||
| foreach ($calls as $call) { | ||
| $call->wait(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
|
|
||
| if ($this->deleteQueue) { | ||
| $this->deleteSessions($this->deleteQueue); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| // gRPC calls appear to cancel when the corresponding UnaryCall object | ||
| // goes out of scope. Keeping the calls in scope allows time for the | ||
| // calls to complete at the expense of a small memory footprint. | ||
| $this->deleteCalls = []; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
efc8c99 to
c68d5bf
Compare
Closes: #490
Please note, the circumvention of the GAPIC client is intended to be temporary until concurrent request support is built into the clients.