Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Release 'api_core-1.6.0a2'? or 'api_core-1.5.1'? #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tswast opened this issue Oct 29, 2018 · 1 comment
Closed

Release 'api_core-1.6.0a2'? or 'api_core-1.5.1'? #6326

tswast opened this issue Oct 29, 2018 · 1 comment
Assignees
@crwilcox
Labels
api: core packaging type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Contributor

tswast commented Oct 29, 2018

I'd like to use the changes from #6310 in the library I'm working on.

Not sure about the version number for that one, since:
@tseaver
Copy link
Contributor

tseaver commented Oct 29, 2018

@tswast I believe @lukesneeringer is the one who can answer your question about PR #6267 and the api_core-1.6.0a1 release.

My take: given that we follow the "keep master releasable at all times" development practice, I believe that we should move the changes from #6267 off onto a branch (or even just revert it and re-merge later) to allow for making an api_core-1.5.1 release from master, including your bugfix from #6310.

As an alternative, we could make an api_core-1.5-maint branch from 7527a4e (the last commit on master touching api_core/ before #6267), and cherry pick e368317 into it from #6310 in order to make the api_core-1.5.1 release you need.

@tseaver tseaver changed the title Release api_core 1.6.0a2 Release 'api_core-1.6.0a2'? or 'api_core-1.5.1'? Oct 29, 2018
@tseaver tseaver added packaging api: core type: process A process-related concern. May include testing, release, or the like. labels Oct 29, 2018
tseaver pushed a commit that referenced this issue Oct 29, 2018
@tswast @tseaver
Don't URL-encode slashes in gRPC request headers. (#6310)
ad1e32f 
Per internal document go/api-url-encoding (approved on 2017-04-20), "the
client library will %-encode everything except "/" and unreserved
characters, and the server will %-decode everything except "%2F"
and %2f"

This is currently affecting a private API which passes a resource name
(containing slashes) as a query parameter over gRPC.

Toward #6326.

(cherry picked from commit e368317)
This was referenced Oct 29, 2018
Merged
Closed
tseaver added a commit that referenced this issue Oct 29, 2018
@tseaver
Back out changes from #6267 / 'api_core-1.6.0a1' release. (#6328)
5961cf6 
We will bring them back in when we have an OK to make a non-alpha
'api_core-1.6.0' release.

Toward #6326.
@tseaver tseaver mentioned this issue Oct 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crwilcox crwilcox

Labels
api: core packaging type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tseaver @tswast @crwilcox