feat(bigquery): add timeout parameter to client's and job's public methods #10002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for internal consistency with other methods such as reload().
AN exception is the Client.load_table_from_file() method, and the methods that depend on it, because adding a timeout requires changes in the google-resumable-media dependency.
plamut
commented
Dec 20, 2019
|
@tswast This PR can be reviewed now. I still have to add a few final tests for handling the timeout in multi-request methods. I might not be able to finish them today, but that shouldn't be a review blocker (will complete on Monday). Edit: The tests failure is because the new test dependency |
If a method makes multiple requests and is given a timeout, that timeout should represent the total allowed time for all requests combined.
Run black? |
tswast
reviewed
Dec 23, 2019
tswast
approved these changes
Dec 26, 2019
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9987.
This PR adds a
timeoutparameter to the public methods of client and job classes.TODO
Adjust tests to verify that atimeoutpassed to a method is indeed forwarded to the underlying transport.result()-timeoutshould be split among all requests, as opposed to using the timeout for each individual request.Open a separate issue for adding a timeout toload_table_from_*()methods that depend on file upload classes fromgoogle-resumable-media- the latter dependency does not support passing an explicit timeout argument to the underlying transport.Done - #10005.
PR checklist